From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Wander Winkelhorst <w(dot)winkelhorst(at)gmail(dot)com> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Improve autocompletion for SELECT statements |
Date: | 2011-11-15 09:03:13 |
Message-ID: | CA+OCxowXxuqajm2VAXKcSG4sOn=Y+VmeSfuxD4t3_gTqMuuZLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, Nov 14, 2011 at 8:15 PM, Wander Winkelhorst
<w(dot)winkelhorst(at)gmail(dot)com> wrote:
>
>
> On Mon, Nov 14, 2011 at 10:16 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> FYI, I just took a look at the patch and it does touch
>> tab-complete.inc - it certainly should *not* do that, as
>> tab-complete.inc is generated with tabcomplete.pl from the upstream
>> tab-complete.c. Any changes made to it are likely to be lost the next
>> time it's updated. If that file must be changed, then it should be
>> done by tab-complete.pl, though frankly it would be better to push the
>> changes into psql first.
>
> Could you please tell me how I'm supposed to use tabcomplete.pl, and where I
> can get the correct version of tab-complete.c?
I'm not sure I've ever used it - that was originally written by Magnus
so I think he handled it originally.
The top of the script has this:
# This script builds tab-complete.inc from tab-complete.c. The
# source file (tab-complete.c) should be copied from the latest
# PostgreSQL sources (src/bin/psql/tab-complete.c), so we don't
# have to do all the work ourselves...
By the looks of it you copy tab-complete.c to pgadmin/utils, and then
run the script in that directory. I wouldn't be surprised if it needs
updating though; the tab completion code does get hacked on quite
regularly in PostgreSQL.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Wander Winkelhorst | 2011-11-15 09:31:32 | Re: [PATCH] Improve autocompletion for SELECT statements |
Previous Message | Ashesh Vashi | 2011-11-15 05:03:41 | Re: pgAdmin III commit: Update french translation |