Skip site navigation (1) Skip section navigation (2)

Re: Weird code in pgDomain.cpp

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>
Subject: Re: Weird code in pgDomain.cpp
Date: 2012-04-08 09:54:56
Message-ID: CA+OCxowHa-bq7N6C_E3H5eWm=LwN+xgbrnViP3O5OZi1-PAKeA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Sun, Apr 8, 2012 at 4:44 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Hi,
>
> I was trying to fix a bug on dlgDomain, and I found this code (in
> pgadmin/schema/pgDomain.cpp):
>
> wxString conname = set->GetVal(wxT("conname"));
> if (!conname.StartsWith(wxT("$")))
>    check += wxT("CONSTRAINT ") + qtIdent(conname) + wxT(" ");
>
> I'm wondering why we look for a dollar sign in the first character of a
> check constraint in a domain. It means nothing to me. Could it be some
> GreenPlum or EnterpriseDB specific code? or is it something else?

Not that I recall - Ashesh, Sachin - do you know if it's a PPAS thing?

>
> I'm also wondering if we could drop this code. Doesn't seem to do much,
> and doesn't help us with modifying a check constraint in a domain.

Dunno.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2012-04-09 07:15:28
Subject: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
Previous:From: Guillaume LelargeDate: 2012-04-08 08:44:28
Subject: Weird code in pgDomain.cpp

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group