Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2011-09-06 22:20:17
Message-ID: CA+CSw_tChMN-w-ns_gUPQaV8ftPc8DEw0goN_sbG-StpPGu2vA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Sep 6, 2011 at 10:18 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> I wonder what happens if files in the same subdir are grouped in a
> subgraph.  Is that possible?

Possible, and done. Also added possivility to add .c files to the graph,
coloring by subdir and possibility exclude nodes from the graph. I didn't yet
bother to clean up the code - to avoid eye damage, don't look at the source.

Bad news is that it doesn't significantly help readability for the all nodes
case. See all_with_subgraphs.svgz.  It does help for other cases.
For example parsenodes.h.svgz has the result for
render_includes.py --select='nodes/parsenodes.h+*-*' --subgraphs
and execnodes.h.svgz for
--subgraphs --select='nodes/execnodes.h+*-*'

--
Ants Aasma

Attachment: execnodes.h.svgz
Description: image/svg+xml-compressed (12.5 KB)
Attachment: parsenodes.h.svgz
Description: image/svg+xml-compressed (16.4 KB)
Attachment: all_with_subgraphs.svgz
Description: image/svg+xml-compressed (77.2 KB)
Attachment: render_includes.v2.py
Description: text/x-python (7.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-09-06 22:57:07
Subject: Re: [PATCH] Log crashed backend's query (activity string)
Previous:From: Kevin GrittnerDate: 2011-09-06 22:09:44
Subject: Re: [PATCH] Log crashed backend's query (activity string)

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-09-06 23:43:17
Subject: pgsql: Fix spelling mistake in pgpass documentation change.
Previous:From: Bruce MomjianDate: 2011-09-06 21:32:56
Subject: pgsql: Add documentation suggestion about adding a comment to the topo

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group