Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

From: Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Date: 2011-09-06 22:20:17
Message-ID: CA+CSw_tChMN-w-ns_gUPQaV8ftPc8DEw0goN_sbG-StpPGu2vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Sep 6, 2011 at 10:18 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> I wonder what happens if files in the same subdir are grouped in a
> subgraph.  Is that possible?

Possible, and done. Also added possivility to add .c files to the graph,
coloring by subdir and possibility exclude nodes from the graph. I didn't yet
bother to clean up the code - to avoid eye damage, don't look at the source.

Bad news is that it doesn't significantly help readability for the all nodes
case. See all_with_subgraphs.svgz. It does help for other cases.
For example parsenodes.h.svgz has the result for
render_includes.py --select='nodes/parsenodes.h+*-*' --subgraphs
and execnodes.h.svgz for
--subgraphs --select='nodes/execnodes.h+*-*'

--
Ants Aasma

Attachment Content-Type Size
render_includes.v2.py text/x-python 7.6 KB
all_with_subgraphs.svgz image/svg+xml-compressed 77.2 KB
parsenodes.h.svgz image/svg+xml-compressed 16.4 KB
execnodes.h.svgz image/svg+xml-compressed 12.5 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2011-09-06 23:43:17 pgsql: Fix spelling mistake in pgpass documentation change.
Previous Message Bruce Momjian 2011-09-06 21:32:56 pgsql: Add documentation suggestion about adding a comment to the top o

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-09-06 22:57:07 Re: [PATCH] Log crashed backend's query (activity string)
Previous Message Kevin Grittner 2011-09-06 22:09:44 Re: [PATCH] Log crashed backend's query (activity string)