Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch for error locations

From: Michael Glaesemann <grzm(at)myrealbox(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgreSQL(dot)org
Subject: Re: Proposed patch for error locations
Date: 2006-03-13 07:42:59
Message-ID: C3817205-17E1-4D6C-9D92-ED6045123F92@myrealbox.com (view raw or flat)
Thread:
Lists: pgsql-interfacespgsql-patches
On Mar 13, 2006, at 2:37 , Tom Lane wrote:

> to wit, that we make use of bison's "locations" feature to track token
> positions in the grammar, and add locations to raw parse tree nodes as
> needed.
>
> Some examples of what it can do:

This looks really nice.

> One thing I'm noticing already is that the addition of "at  
> character N"
> to a lot of these messages isn't an improvement.  In psql it's  
> certainly
> redundant with the error-cursor display.

The pure character count is definitely difficult to use with larger  
queries. I think it could be more useful if it were  
line:char_of_line. Would others find this useful?

Michael Glaesemann
grzm myrealbox com




In response to

Responses

pgsql-patches by date

Next:From: ITAGAKI TakahiroDate: 2006-03-13 08:38:01
Subject: Re: [PATCHES] Automatic free space map filling
Previous:From: Neil ConwayDate: 2006-03-13 07:26:31
Subject: Re: Fix syntax errors in contrib uninstall scripts

pgsql-interfaces by date

Next:From: Martijn van OosterhoutDate: 2006-03-13 11:43:31
Subject: Re: Proposed patch for error locations
Previous:From: Tom LaneDate: 2006-03-12 17:37:35
Subject: Proposed patch for error locations

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group