Re: pl/python SPI in subtransactions

From: Steve Singer <ssinger_pg(at)sympatico(dot)ca>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pl/python SPI in subtransactions
Date: 2011-01-29 21:10:17
Message-ID: BLU0-SMTP275B49B34200AC4A7F053C8EE00@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11-01-29 03:39 PM, Jan Urbański wrote:
>
> D'oh, you're right, thanks. Attached patch with fix. Curiosly, right now
> in master your example with plpy.prepare will result in "savepoint"
> being swallowed, but it's of course better to react with an error.
>
> Cheers,
> Jan

This seems to fix it.

You mentioned that you were going to add a few paragraphs to the
documentation saying that you can now actually catch SPI errors. I
haven't seen that yet.

Other than that I don't see any issues with the patch and it should be
ready for a committer.

>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Urbański 2011-01-29 21:13:13 Re: pl/python SPI in subtransactions
Previous Message Jan Urbański 2011-01-29 20:39:24 Re: pl/python SPI in subtransactions