Re: Patch for ALTER DATABASE WITH TABLESPACE

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for ALTER DATABASE WITH TABLESPACE
Date: 2008-11-07 00:13:57
Message-ID: BFA2800A5DD0D2E0DFB25242@imhotep.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

--On Donnerstag, November 06, 2008 11:35:54 +0100 Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> Guillaume Lelarge a écrit :
>> v4 patch attached.
>>
>
> v5 patch attached.
>

Thanks Guillaume.

Maybe this is nit-picking, but i see that you have to rmdir() an existing
empty tablespace directory to use copydir() afterwards. Maybe we can teach
copydir() to error out when trying to mkdir() an existing directory only
when forced by the caller? I see copydir() used at four places, so the
impact of this change would be minimal.

--
Thanks

Bernd

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-11-07 00:25:38 Re: [WIP] In-place upgrade
Previous Message Greg Smith 2008-11-06 23:51:20 Re: [WIP] In-place upgrade