Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

From: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow ALTER TABLE name {OF type | NOT OF}.
Date: 2011-05-27 22:37:05
Message-ID: BANLkTiny0PJTa9Ogcw2E=RmkRq=cZQignw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
2011/4/21 Robert Haas <rhaas(at)postgresql(dot)org>:
> Allow ALTER TABLE name {OF type | NOT OF}.
>
> This syntax allows a standalone table to be made into a typed table,
> or a typed table to be made standalone.  This is possibly a mildly
> useful feature in its own right, but the real motivation for this
> change is that we need it to make pg_upgrade work with typed tables.
> This doesn't actually fix that problem, but it's necessary
> infrastructure.
>
> Noah Misch
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/68739ba856c52e6721d6cffec21f1bf0327a9a7b
>
> Modified Files
> --------------
> doc/src/sgml/ref/alter_table.sgml         |   26 +++
> src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--

I noticed 2 warnings on unused variables from gcc in tablecmds.c
The attached patch fix that by removing those 2 variables.

> src/backend/parser/gram.y                 |   17 ++
> src/backend/parser/parse_utilcmd.c        |   22 +---
> src/include/commands/tablecmds.h          |    2 +
> src/include/nodes/parsenodes.h            |    2 +
> src/test/regress/expected/alter_table.out |   38 ++++
> src/test/regress/sql/alter_table.sql      |   30 +++
> 8 files changed, 376 insertions(+), 38 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>



-- 
Cédric Villemain               2ndQuadrant
http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support

Attachment: fix_warning_gcc.patch
Description: text/x-patch (775 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Greg StarkDate: 2011-05-27 22:44:38
Subject: Re: dblink crash on PPC
Previous:From: Christopher BrowneDate: 2011-05-27 22:10:37
Subject: Re: How can I check the treatment of bug fixes?

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2011-05-28 01:51:57
Subject: pgsql: Remove unused variable
Previous:From: Peter EisentrautDate: 2011-05-27 22:02:16
Subject: pgsql: Remove literal tabs from message strings

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group