Skip site navigation (1) Skip section navigation (2)

Re: [pgadmin-support] Reconnection problem.

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: PgAdmin Support <pgadmin-support(at)postgresql(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Piotr Czekalski <pczekalski(at)techbaza(dot)pl>
Subject: Re: [pgadmin-support] Reconnection problem.
Date: 2011-05-02 08:20:21
Message-ID: BANLkTinWZ5A0Rj6FB3ERDc0KdtAc2fm_BQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackerspgadmin-support
On Sun, May 1, 2011 at 4:32 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Hi,
>
> On 04/26/2011 12:46 PM, Piotr Czekalski wrote:
>> [...]
>> I'd would appreciate such feature, because working over GSM modem, which
>> is common to the administrators novadays (I think) is a nightmare ;-).
>>
>
> Got a patch that works. See the attachment. If the query fails, it
> checks if it's because of a bad connection. If connection is bad, it
> resets it, and executes once again the query. If it still fails, you
> have the usual error message. If it succeeds, you won't even notice that
> it had to reset the connection.
>
> I don't see any issue with this patch, but would like others to get a
> look. It's wxThread and that kind of stuff is not really my thing
> (threading... eeks).
>
> And one more question, we're really early in beta stage. Usually, it
> would have to wait a few months to get commited in next dev cycle. But
> it is so early in this stage (actually, beta 1 is not even announced
> yet), and it would be a so much welcomed patch that I think it could be
> commited for this release (ie, 1.14).
>
> Any opinions, objections, ideas?

You cannot just reconnect silently in a patch like this - the user may
have created temp tables or otherwise modified the connection-specific
environment before the connection was lost. Blindly reconnecting and
then executing the query could have disastrous effects.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-05-02 20:07:13
Subject: pgAdmin III commit: Update russian translation
Previous:From: Guillaume LelargeDate: 2011-05-01 21:26:17
Subject: Re: pgAdmin 1.14 Visual Tour

pgadmin-support by date

Next:From: Francisco LeoveyDate: 2011-05-02 15:03:16
Subject: PgAdmin no longer works on a "clean install" XP SP2
Previous:From: Guillaume LelargeDate: 2011-05-01 15:55:38
Subject: Re: bug report - quote parameters send to plugins

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group