Skip site navigation (1) Skip section navigation (2)

Re: Fwd: Keywords in pg_hba.conf should be field-specific

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: Keywords in pg_hba.conf should be field-specific
Date: 2011-06-28 20:19:02
Message-ID: BANLkTinOsQhgOhdek1KQm3VsVdwfugpdfg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2011/6/28 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Excerpts from Pavel Stehule's message of dom jun 26 13:10:13 -0400 2011:
>> Hello
>>
>> >
>> > I have touched next_token() and next_token_expand() a bit more, because
>> > it seemed to me that they could be simplified further (the bit about
>> > returning the comma in the token, instead of being a boolean return,
>> > seemed strange).  Please let me know what you think.
>>
>> I am thinking, so it is ok.
>
> Thanks, I have pushed it.  Brendan: thanks for the patch.
>
>> I am not sure, if load_ident is correct. In load_hba you clean a
>> previous context after successful processing. In load_ident you clean
>> data on start. Is it ok?
>
> Yeah, they are a bit inconsistent.  I am uninclined to mess with it,
> though.  Right now it seems to me that the only way it could fail is if
> you hit an out-of-memory or a similar problem.  And if you hit that at
> postmaster startup ... well ... I guess you have A Problem.

there should be a format (syntax) error. If somebody breaks a pg_ident
and will do a reload, then all ident mapping is lost.

This is not related to topic or doesn't modify current behave, so
should not be repaired now

Pavel

>
> If somebody wants to submit a patch to fix that, be my guest.
>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>

In response to

Responses

pgsql-hackers by date

Next:From: Florian PflugDate: 2011-06-28 20:20:50
Subject: Re: Range Types, constructors, and the type system
Previous:From: Robert HaasDate: 2011-06-28 20:18:46
Subject: Re: spinlock contention

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group