Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Install adminpack on user request in frmStatus

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Install adminpack on user request in frmStatus
Date: 2011-04-19 08:40:56
Message-ID: BANLkTimnv6KdNys5JcSD1Au+W_tq1cHovA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi Guillaume,

I've tweaked the wording on the message in this patch as I wasn't
entirely happy with the phrasing, but whilst doing so I noticed there
doesn't seem to be any error checking to handle the case where the
extension cannot be installed (for example, because the user is using
a hosting site which hasn't installed the contrib modules).

There's also no way to permanently suppress the message box, which
could become very annoying.

Final thought - we also have a guru hint about the admin pack
(instrumentation.html). Shouldn't this patch touch the same places as
that hint (as well as anywhere else it makes sense)?

On Mon, Apr 18, 2011 at 9:23 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Install adminpack on user request in frmStatus
>
> Now that we can install an extension quite easily, it's simpler to ask the
> user if he wants pgAdmin to install it, rather than displaying him a hint. We
> still do that if it's not an 9.1 server or if the server doesn't have the
> adminpack extension installed.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bd13fc270aaf7fdf007c7ea94969c1fbfeb4f9fe
>
> Modified Files
> --------------
> pgadmin/db/pgConn.cpp       |    4 ++--
> pgadmin/frm/frmStatus.cpp   |   30 ++++++++++++++++++++++++++----
> pgadmin/include/db/pgConn.h |    2 +-
> 3 files changed, 29 insertions(+), 7 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-04-19 09:48:03
Subject: Re: pgAdmin III commit: Install adminpack on user request in frmStatus
Previous:From: Dave PageDate: 2011-04-19 08:34:24
Subject: pgAdmin III commit: Improve message wording.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group