Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Message style cleanup

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Message style cleanup
Date: 2011-05-04 18:32:49
Message-ID: BANLkTim5vK2NUDByqgXEwOaQv=AXMyoFvA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Is this part really correct?

-       fprintf(stderr, _("%s: final receive failed: %s\n"),
+       fprintf(stderr, _("%s: final receive failed: %s"),

all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too  many?
(There are a couple of other examples of removing the \n though, so
perhaps it was  intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?

//Magnus

On Wed, May 4, 2011 at 20:10, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Message style cleanup
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/bff074b1ab0dfed7a7822dcc8942f877efa3b914
>
> Modified Files
> --------------
> src/bin/pg_basebackup/pg_basebackup.c |   62 ++++++++++++++++----------------
> 1 files changed, 31 insertions(+), 31 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers
>



-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Darren DuncanDate: 2011-05-04 18:33:33
Subject: Re: VARIANT / ANYTYPE datatype
Previous:From: Tom LaneDate: 2011-05-04 18:31:03
Subject: Re: Unfriendly handling of pg_hba SSL options with SSL off

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-04 19:02:49
Subject: pgsql: Include unary plus in the Operator Precedence table.
Previous:From: Peter EisentrautDate: 2011-05-04 18:10:38
Subject: pgsql: Fix alignment of --help output

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group