Skip site navigation (1) Skip section navigation (2)

Re: Rework on the dialogs UI

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Rework on the dialogs UI
Date: 2011-04-08 10:35:11
Message-ID: BANLkTiktMx=mCb2Jzr2-oP5uvXxWmQJuPA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Fri, Apr 8, 2011 at 10:50 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> I think I know why. The OnChangeSize() method is specific to the Mac
> platform. It substracts 550 to the height, but I lower the height a bit,
> so 550 is probably too big now.

Ahh no - it's because securityPage is NULL for a catalog dialogue - it
just needs the first 2 lines to be guarded with "if (securityPage)".
Not sure what the size is for - it seems to work whatever I set that
too.

>> I wonder if it should be 300 wide? The tab labels are all visible now,
>> but the edges aren't.
>>
>
> Done in the patch attached.

Looks better.

>>>>  * big one: 270,250
>>>>
>>>> But it seems I forgot dlgServer and dlgTable. Just fixed dlgServer.
>>>> Working on dlgTable right now.
>>>>
>>>
>>> Fixed too.
>>
>> :-)

Hmm, actually the height is still an issue on the Privileges page. See
the attached screenshot.

>>> I fixed also the frmOptions window.
>>
>> Not quite - see the attached screenshot.
>>
>
> Should be fixed in the patch attached.

Still a little too small - see the other screenshot.

>> BTW, that one also seems to be missing the status bar. Wanna fix that
>> while you're there?
>>
>
> AFAIR, there is no status bar in the frmOptions window. Do you really
> want to add it to this window? what for?

It looks a bit crappy for a start - particularly the positioning of
the OK/Cancel buttons. Also for consistency with the other dialogues,
which I think all have a status bar these days.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment: Screen shot 2011-04-08 at 11.16.01.png
Description: image/png (103.2 KB)
Attachment: Screen shot 2011-04-08 at 11.16.43.png
Description: image/png (94.6 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-04-08 13:38:34
Subject: Re: Rework on the dialogs UI
Previous:From: Guillaume LelargeDate: 2011-04-08 09:50:52
Subject: Re: Rework on the dialogs UI

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group