Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed
Date: 2011-06-29 14:34:40
Message-ID: BANLkTikg3smRV3WmYXOs1WdsuH80unaifQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, Jun 29, 2011 at 16:30, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Jun 28, 2011 at 19:45, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
>> Excerpts from Tom Lane's message of mar jun 28 10:39:22 -0400 2011:
>>
>>> I think it would be sensible to block branch removal, as there's
>>> basically never a scenario where we'd do that during current usage.
>>> I'm not excited about blocking branch addition, although I worry
>>> sooner or later somebody will accidentally push a private development
>>> branch :-(.  Is it possible to block only removal and not addition?
>>
>> If we can tweak the thing, how about we only allow creating branches
>> that match a certain pattern, say ^REL_\d+_\d+_STABLE$?
>
> I've put this in place - except I used ^REL\d+... and not what you
> suggested, since that's how we name our branches :P
>
> I'm going to push an actual valid branch, let's say 9.7, and then
> remove it again, just to make sure things worked (with it installed I
> cannot push an invalid branch, so i can't test the branch removal
> block). So don't panic if you see that one :)

Ok, I'm done experimenting and this is now in production.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2011-06-29 15:03:36 Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed
Previous Message pgsql 2011-06-29 14:33:25 pgsql: Branch refs/heads/REL9_7_STABLE was removed

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2011-06-29 15:03:36 Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed
Previous Message Magnus Hagander 2011-06-29 14:30:51 Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed