Re: psql describe.c cleanup

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql describe.c cleanup
Date: 2011-06-16 14:05:30
Message-ID: BANLkTi=mUrBib+DhvovG3XkUQUxizKqkmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 15, 2011 at 9:01 AM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
> On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
>> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
>>> What I do wonder though is if the ; appending should really be
>>> happening in printQuery() instead of in each query -- the idea being
>>> that formatting for external consumption should be happening in one
>>> place.  Maybe that's over-thinking it though.
>>
>> That's a fair point, and hacking up printQuery() would indeed solve my
>> original gripe about copy-pasting queries out of psql -E. But more
>> generally, I think that standardizing the style of the code is a Good
>> Thing, particularly where style issues impact usability (like here).
>
> sure -- if anyone would like to comment on this one way or the other
> feel free -- otherwise I'll pass the patch up the chain as-is...it's
> not exactly the 'debate of the century' :-).

done. marked ready for committer.

merlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-06-16 14:10:49 Re: Patch - Debug builds without optimization
Previous Message Tom Lane 2011-06-16 13:51:53 Re: [Streaming] Datum compression