Re: Negative Integers Escaping

From: Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>
To: Federico Di Gregorio <federico(dot)digregorio(at)dndg(dot)it>
Cc: psycopg(at)postgresql(dot)org
Subject: Re: Negative Integers Escaping
Date: 2011-05-30 21:18:12
Message-ID: BANLkTi=CmNqYBBbV0SvrOdL9JiFPzU-AXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: psycopg

On Sun, May 29, 2011 at 9:04 PM, Federico Di Gregorio
<federico(dot)digregorio(at)dndg(dot)it> wrote:

> A mathematical expression doesn't need, at least in SQL, any whitespace
> so, writing colname-%s is *correct* and the programmer is correct when
> expects the DB adapter to quote the arguments to make sure they don't
> introduce any new errors in SQL.

Groan... https://github.com/dvarrazzo/psycopg/commit/281427f450d6e9755d4c3cbc9fb159d45ca10ee6

tl:dr: added space in front of negative sign for all the numeric
types. With this patch the unit test doesn't report any failure, so I
hope no regression.

-- Daniele

In response to

Browse psycopg by date

  From Date Subject
Next Message Marko Kreen 2011-05-31 11:47:28 Re: Negative Integers Escaping
Previous Message Federico Di Gregorio 2011-05-29 20:04:02 Re: Negative Integers Escaping