Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

From: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.
Date: 2011-05-28 07:05:17
Message-ID: BANLkTi=0zF6DFeKCQyAJMX=DV3uo5coQfQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
2011/5/28 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Excerpts from Cédric Villemain's message of vie may 27 18:37:05 -0400 2011:
>> 2011/4/21 Robert Haas <rhaas(at)postgresql(dot)org>:
>
>> > Modified Files
>> > --------------
>> > doc/src/sgml/ref/alter_table.sgml         |   26 +++
>> > src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
>>
>> I noticed 2 warnings on unused variables from gcc in tablecmds.c
>> The attached patch fix that by removing those 2 variables.
>
> My compiler wasn't complaining, but since the variable is clearly unused
> I went ahead and pushed this.  Thanks

I have a recent gcc wich probably help here:
gcc-4.6.real (Debian 4.6.0-7) 4.6.1 20110507 (prerelease)


>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>



-- 
Cédric Villemain               2ndQuadrant
http://2ndQuadrant.fr/     PostgreSQL : Expertise, Formation et Support

In response to

pgsql-hackers by date

Next:From: nil nilDate: 2011-05-28 08:39:53
Subject: patch integration
Previous:From: tomasDate: 2011-05-28 06:26:53
Subject: Re: storing TZ along timestamps

pgsql-committers by date

Next:From: Tom LaneDate: 2011-05-28 16:38:28
Subject: pgsql: Fix null-dereference crash in parse_xml_decl().
Previous:From: Alvaro HerreraDate: 2011-05-28 01:53:52
Subject: Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group