From: | "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
---|---|
To: | "Peter Eisentraut" <peter_e(at)gmx(dot)net> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Redefine _() to dgettext() instead of gettext() so that it uses |
Date: | 2009-03-02 14:44:03 |
Message-ID: | B931FEADCC0D4A1799C008E7C7D6777A@HIRO57887DE653 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi Peter-san.
I see the problem for being an original domain in plpgsql. It differs from what
codeset meant at postmaster by Japanese windows....
Please see, this look at the problem on which SJIS enters into a message.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/plpgsql/before_plpgsql_server.log
This state is the following.
==
lc_messages=ja
server_encoding=utf-8
==
Therefore, it needs to be codeset called for an original domain. It is the procedure in which
only a server module must correspond. Then, It is solvable by this patch.
http://winpg.jp/~saito/pg_work/LC_MESSAGE_CHECK/plpgsql/after_plpgsql_server.log
Please take this into consideration.
Tahnks.
Regards,
Hiroshi Saito
----- Original Message -----
From: "Peter Eisentraut" <peter_e(at)gmx(dot)net>
> Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>>> Log Message:
>>> -----------
>>> Redefine _() to dgettext() instead of gettext() so that it uses the plpgsql
>>> text domain, instead of the postgres one (or whatever the default may be).
>>
>> Hmm, so is this needed on all other PLs too?
>
> In principle yes. Or call dgettext() explicitly, which is also done in
> some cases. However, in most cases messages are issued through
> ereport(), which handles this automatically (which you implemented, I
> recall).
Attachment | Content-Type | Size |
---|---|---|
pl_domain_codeset_patch.txt | text/plain | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2009-03-02 15:10:09 | pgsql: Fix usage of char2wchar/wchar2char. |
Previous Message | User Itagaki | 2009-03-02 11:35:36 | textsearch-ja - textsearch-ja: Fix normalization routine for full-width |
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2009-03-02 15:15:25 | Re: regression test crashes at tsearch |
Previous Message | Hannu Krosing | 2009-03-02 14:12:37 | Re: xpath processing brain dead |