Skip site navigation (1) Skip section navigation (2)

Re: Move WAL warning

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Move WAL warning
Date: 2011-02-02 17:00:42
Message-ID: AANLkTinyu-0LdC=fNvv8BgxeKqjomP6KGVd8hRGqvDNO@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Feb 2, 2011 at 17:43, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 02.02.2011 16:36, Magnus Hagander wrote:
>>
>> When running pg_basebackup with -x to include all transaction log, the
>> server will still throw a warning about xlog archiving if it's not
>> enabled - that is completely irrelevant since pg_basebackup has
>> included it already (and if it was gone, the base backup step itself
>> will fail - actual error and not warning).
>>
>> This patch moves the warning from do_pg_base_backup to pg_base_backup,
>> so it still shows when using the explicit function calls, but goes
>> away when using pg_basebackup.
>
> For the sake of consistency, how about moving the "pg_stop_backup complete,
> all required WAL segments have been archived" notice too?

Well, it goes out as a NOTICE, so by default it doesn't show.. But
yeah, for code-consistency it makes sense. Like so, then.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment: stop_backup_warning.patch
Description: text/x-patch (1.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2011-02-02 17:03:07
Subject: Re: ALTER EXTENSION UPGRADE, v3
Previous:From: David E. WheelerDate: 2011-02-02 16:50:59
Subject: Re: ALTER EXTENSION UPGRADE, v3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group