Skip site navigation (1) Skip section navigation (2)

Re: review: psql: edit function, show function commands patch

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: psql: edit function, show function commands patch
Date: 2010-07-25 15:42:57
Message-ID: AANLkTinxFffNw+wmkNJFht85OugoMPKPw+WojbtM-pYw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/7/25 Jan Urbański <wulczer(at)wulczer(dot)org>:
> On 23/07/10 20:55, Pavel Stehule wrote:
>> Hello
>>
>> 2010/7/23 Jan Urbański <wulczer(at)wulczer(dot)org>:
>>> On 21/07/10 14:43, Pavel Stehule wrote:
>>>> Hello
>>>>
>>>> I am sending a actualised patch.
>
> OK, thanks. This time the only thing I'm not happy about is the error
> message from doing:
>
> \ef func 0
> \e /etc/passwd xxx
>
> which gives:
>
> line number is unacceptable
>
> where I think it should do:
>
> \ef: line number is unacceptable
> \e: line number is unacceptable
>
> but that's too trivial to go through another round of review and I think
> the committer can fix this easily.
>
> The documentation likely needs some spelling fixes, but I'll leave that
> to a native English speaker.
>
> I'm setting this as ready for committer.

Thank you very much

Pavel
>
> Thanks,
> Jan
>

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-07-25 21:32:08
Subject: Re: including backend ID in relpath of temp rels - updated patch
Previous:From: Jan UrbańskiDate: 2010-07-25 15:36:16
Subject: Re: review: psql: edit function, show function commands patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group