Skip site navigation (1) Skip section navigation (2)

Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum
Date: 2010-11-02 12:49:44
Message-ID: AANLkTinor=5M2WobKUKdfukj_HqhYt-Q6s-e9CW8EKyo@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Nov 1, 2010 at 2:51 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 31/10/2010 09:44, Guillaume Lelarge a écrit :
>> Le 31/10/2010 00:39, Dave Page a écrit :
>>> On Sun, Oct 31, 2010 at 1:56 AM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 30/10/2010 10:25, Dave Page a écrit :
>>>>
>>>>> Yeah, that's really nasty. I guess we need split the commands at ;.
>>>>
>>>> Yeah. If it's not between quotes. I don't like it at all, but I don't
>>>> see another way of doing it.
>>>>
>>>>> I guess we should pass a flag down somehow to tell the function that
>>>>> executes the query to do that and then we could also potentially get
>>>>> rid of the double SQL boxes.  I'm not looking at the code, but I
>>>>> suspect that'll be nasty.
>>>>>
>>>>
>>>> We actually aren't required to add such a flag. We can check if the
>>>> query contains "ALTER TYPE", and "ADD AFTER" or "ADD BEFORE".
>>>
>>> That's knowledge I'd rather avoid hardwiring into the lower level
>>> machinery here.
>>>
>>
>> So do I. I tried a few things yesterday. Changing the apply() and
>> GetSql() parameters imply to change all GetSql for all dlg* source code.
>> That will be quite an invasive patch.
>>
>
> I've done the "split-the-queries" function. Seems to work great, but
> still doesn't cover dollar quoting. Anyway, it's less ugly than I
> thought. The interesting part is dlgProperty::SplitQueries(). Would love
> to get comments :)

I just eyeballed the patch - if I'm reading it right, it splits *all*
queries and executes each part individually. Is that correct?

If so, we're going to need that flag. Most of the time, we want all
the query parts to be executed atomically, otherwise if we get and
error (particularly when using the Apply button where there is one),
the dialogue won't know what parts of the update work and what didn't,
and thus will have a difficult job refreshing the display
appropriately.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-11-02 14:18:24
Subject: Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum
Previous:From: Guillaume LelargeDate: 2010-11-01 21:51:30
Subject: Re: Ticket 269: Add support for 9.1 ALTER TYPE new syntax for enum

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group