From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Git configuration |
Date: | 2010-07-27 12:12:52 |
Message-ID: | AANLkTinfLK2cfcmf8UBxinr-jeoqxyZx-xgXpdmZt6+d@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Jul 27, 2010 at 1:10 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 27/07/2010 13:08, Dave Page a écrit :
>> On Tue, Jul 27, 2010 at 11:16 AM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Le 27/07/2010 11:37, Dave Page a écrit :
>>>> On Tue, Jul 27, 2010 at 10:30 AM, Guillaume Lelarge
>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>
>>>>> Did you fix the script? do you need help? I can probably take some time
>>>>> to look at it.
>>>>
>>>> Not yet. Feel free. It's in commitmsg.py iirc:
>>>>
>>>> http://github.com/mhagander/pg_githooks
>>>>
>>>
>>> Well, I could be completely wrong but I think you just need to change
>>> one parameter in hook/policyenforce.ini: committerequalsauthor must be
>>> equal to 0. If you do this, the hook won't try to match commiter's and
>>> author's name, but it will still enforce commiters. Which is what we
>>> want, right?
>>
>> That isn't the problem (and committerequalsauthor is already zero).
>> The problem is that the commitmsg script sends the email "from" the
>> author, not the committer.
>>
>
> Oh OK. I thought I still couldn't use the --author CLI option. Now, I
> understand the issue. I'll try to work on this today.
Well you shouldn't, as it will send email in someone else's name until
this is fixed.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2010-07-27 12:22:53 | Re: 1.10.5 ? |
Previous Message | Guillaume Lelarge | 2010-07-27 12:10:34 | Re: Git configuration |