Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
Date: 2011-01-04 19:07:47
Message-ID: AANLkTinewPvjR6QxkBCFAqECohTs83+=Xi-b888HP1HJ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>wrote:

> Hi Magnus/Dave,
>
> This check-in has added one compilation error.
> The following line introduce an error in file '*pgadmin/db/keywords.c*'
> *#include <server/parser/gram.h>
> #include <server/parser/kwlist.h>*
>
> Because - these header files does not always find under *`pg_config
> --includedir`* folder, but can be found under *`pg_config --pkgincludedir`
> *.
>
> Please find the patch to resolve the issue. This applies on both master and
> REL-1_12_PATCHES branch.
>
>
Looks good in general, but do we actually need to put it on 1.12? The
keyword build changes were only applied to master, so unless we actually
*need* it on the back branch, I don't think we should put it there.  Is it
needed for something else as well?



-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2011-01-04 20:23:17
Subject: [pgAdmin III] #296: Uncalled CREATE OR REPLACE VIEW in privileges dialog
Previous:From: Ashesh VashiDate: 2011-01-04 17:46:40
Subject: Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group