| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects. |
| Date: | 2011-04-01 17:37:58 |
| Message-ID: | AANLkTineR1KcA0HkVX-BiOQ0ev-fiWm-vruNExDJ8_mR@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Apr 1, 2011 at 11:57 AM, Thom Brown <thom(at)linux(dot)com> wrote:
> On 1 April 2011 16:28, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> Support comments on FOREIGN DATA WRAPPER and SERVER objects.
>>
>> This mostly involves making it work with the objectaddress.c framework,
>> which does most of the heavy lifting. In that vein, change
>> GetForeignDataWrapperOidByName to get_foreign_data_wrapper_oid and
>> GetForeignServerOidByName to get_foreign_server_oid, to match the
>> pattern we use for other object types.
>
> Should we also have support for comments on user mappings?
Oh, bugger. Yeah, probably.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2011-04-01 18:01:40 | pgsql: Avoid palloc before CurrentMemoryContext is set up on win32 |
| Previous Message | Robert Haas | 2011-04-01 17:16:58 | pgsql: Tab completion for COMMENT ON FOREIGN DATA WRAPPER / SERVER. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2011-04-01 17:38:11 | Reminder: cluster-hackers meeting at pgCon |
| Previous Message | Kevin Grittner | 2011-04-01 17:20:25 | Re: trivial patch: show SIREAD pids in pg_locks |