Thank you for review and code refactoring.
PS: when comparing with gbt_num_picksplit, I noticed that that one does not
> update v->spl_ldatum and spl_rdatum to the union datums, but initializes
> these to 0 at the beginning and never seems to update them. Not sure if this
> is a problem since the num_picksplit stuff seems to work well.
Actually gbt_num_picksplit updates v->spl_ldatum and spl_rdatum
inside gbt_num_bin_union function.
With best regards,
In response to
pgsql-hackers by date
|Next:||From: Dimitri Fontaine||Date: 2010-11-05 16:16:37|
|Subject: Re: ALTER OBJECT any_name SET SCHEMA name|
|Previous:||From: Alvaro Herrera||Date: 2010-11-05 16:10:20|
|Subject: Re: why does plperl cache functions using just a bool for is_trigger|