Skip site navigation (1) Skip section navigation (2)

Re: Fix for seg picksplit function

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Yeb Havinga <yebhavinga(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for seg picksplit function
Date: 2010-11-05 16:15:55
Message-ID: AANLkTinderiVZ11MnSMVDpgr3Em5dJTQfVO0BhO2ULTP@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hello Yeb,

Thank you for review and code refactoring.

PS: when comparing with gbt_num_picksplit, I noticed that that one does not
> update v->spl_ldatum and spl_rdatum to the union datums, but initializes
> these to 0 at the beginning and never seems to update them. Not sure if this
> is a problem since the num_picksplit stuff seems to work well.
>
Actually gbt_num_picksplit updates v->spl_ldatum and spl_rdatum
inside gbt_num_bin_union function.

----
With best regards,
Alexander Korotkov.

In response to

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2010-11-05 16:16:37
Subject: Re: ALTER OBJECT any_name SET SCHEMA name
Previous:From: Alvaro HerreraDate: 2010-11-05 16:10:20
Subject: Re: why does plperl cache functions using just a bool for is_trigger

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group