Skip site navigation (1) Skip section navigation (2)

Re: [pgAdmin III] #209: "Connect to Server" dialog buggy

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin III] #209: "Connect to Server" dialog buggy
Date: 2010-07-13 08:31:29
Message-ID: AANLkTindblPZPDDOG59RC4p9T_wEgXfsV1yV3O0-5BAd@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Thanks - applied.

On Mon, Jul 12, 2010 at 1:21 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> Hi Dave,
> PFA the updated patch.
> [Please check my inline answers.]
>
> On Mon, Jul 12, 2010 at 4:37 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Mon, Jul 12, 2010 at 11:39 AM, Ashesh Vashi
>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> > Hi Dave,
>> > Please find the patch for the same.
>>
>> Thanks. This looks good to me following some quick testing, but I
>> uncovered some other issues - could you look at them please?
>>
>> - We seem to stop populating the server combo box as soon as we find
>> the one we're currently connected to. This happens at ~ line 286 in
>> dlgSelectConnection.cpp, where we set foundServer = true. I can't see
>> why we do this, but it seems fairly deliberate. Any guesses? Should we
>> just remove that?
>
> My mistake - I introduced that variable in the previous patch.
>>
>> - It seems like we ignore sslmode when we create new connections. We
>> need to honour the server config.
>
> Done.
>>
>> Note that I haven't tested to ensure this doesn't break anything in
>> command line startup mode (eg. with -q). Can you please ensure this
>> mode is unaffected?
>
> Tested.
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise Postgres Company
>
>



-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

pgadmin-hackers by date

Next:From: pgAdmin TracDate: 2010-07-13 13:56:42
Subject: [pgAdmin III] #212: Changes to functions via properties dialog not displayed
Previous:From: svnDate: 2010-07-13 08:31:22
Subject: SVN Commit by dpage: r8467 - in trunk/pgadmin3/pgadmin: . dlg frm include/dlg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group