Re: Patch to add GIT support

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Robert Haas <robert(dot)haas(at)enterprisedb(dot)com>
Subject: Re: Patch to add GIT support
Date: 2010-06-28 12:23:12
Message-ID: AANLkTinaD-HErRd1Kw_cQUAQuVrFbGB3UMABfFQnbyXW@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

OK, I applied the attached patch to TRUNK. I didn't bother with the
back branches - they'll just show up with a revision number of
'Unknown' anyway, and it's not like we're going to release any more
versions from them.

On Mon, Jun 28, 2010 at 7:39 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> No objection from my end. :P
> Looks good to me.
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company
>
> On Fri, Jun 25, 2010 at 10:06 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> The attached patch to the build system adds the ability for version
>> stamping to happen either when working in an SVN repo or GIT repo. In
>> an SVN repo, it will stamp the repo version number, such as 2134:2137M
>> as the current code does. In a GIT repo, it'll stamp the short version
>> of the last commit hash - eg. 42c03da.
>>
>> Thanks to some^Wa lot of help from Robert Haas, it also manages to fix
>> the old problem in which the build system always thought that the
>> svnversion.h header had changed, thus resulting in svnversion.cpp
>> being recompiled and everything being relinked, regardless of whether
>> anything actually did change.
>>
>> I need to do something similar for VC++, but does anyone object to
>> this? The intention is to apply it to all important branches so when
>> we move to GIT, they'll just work.
>>
>> --
>> Dave Page
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise Postgres Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachment Content-Type Size
pgadmin-build-scm.diff application/octet-stream 3.9 KB

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2010-06-29 20:14:44 Ticket 4: better i18n
Previous Message svn 2010-06-28 12:22:04 SVN Commit by dpage: r8448 - in trunk/pgadmin3/pgadmin: . frm