Re: [DOCS] Remove name as valid parameter for catalog functions

From: Thom Brown <thom(at)linux(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-docs <pgsql-docs(at)postgresql(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [DOCS] Remove name as valid parameter for catalog functions
Date: 2011-03-07 17:36:12
Message-ID: AANLkTinZa6Gg5M=jT689bm5qA=40vMuEh60zE+5KmDb7@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgsql-docs

On 7 March 2011 20:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thom Brown <thom(at)linux(dot)com> writes:
>> Patch attached which corrects the docs where catalog functions no
>> longer accept values of type name.  Originally a note submitted by
>> someone on the docs, but this affects more than just the one they
>> mentioned.
>
> The reason those are phrased as "OID or name" is that what they take is
> regclass, which means that things like pg_total_relation_size('table_name')
> do in fact work.  I think the proposed wording would leave people with
> the idea that they had to supply a numeric OID, which is a PITA and not
> by any means the expected usage.  I agree that maybe the original
> wording could use some improvement, but I don't think that just removing
> "or name" is an improvement.

That's fair enough, but it still needs changing, as whilst an OID
won't cause an error, a field with the type of name will. Is it
reasonable to refer to a parameter as required to be of type regclass?

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Tom Lane 2011-03-07 18:00:53 Re: Remove name as valid parameter for catalog functions
Previous Message Dave Page 2011-03-07 17:18:17 Re: s/xpm/png/g

Browse pgsql-docs by date

  From Date Subject
Next Message David Fetter 2011-03-07 17:51:06 Re: [HACKERS] Sync rep doc corrections
Previous Message Thom Brown 2011-03-07 17:23:17 Re: Sync rep doc corrections