| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Date: | 2011-03-08 03:04:34 |
| Message-ID: | AANLkTinXFfS3we4=Qj29kyTB0=thVjhAGmk1UOic8V7p@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 9, 2011 at 5:12 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> I was also worried about the non-hot-standby case, but I see that the
> patch makes sure you can't enable pause when not in hot standby mode.
> Which in itself might be surprising - perhaps we need a NOTICE for
> when that happens as well?
I didn't include this fix in the patch because I prefer FATAL to
NOTICE for that.
NOTICE doesn't stop recovery. So we might be unable to notice such a NOTICE
message and stop the recovery before it's too late, i.e., the recovery has
completed at the undesirable point. So I think that emitting FATAL is safer.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-03-08 03:29:06 | Re: pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| Previous Message | Tom Lane | 2011-03-08 03:04:26 | Re: pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-03-08 03:28:45 | Re: Parallel make problem with git master |
| Previous Message | Tom Lane | 2011-03-08 03:04:26 | Re: pgsql: Basic Recovery Control functions for use in Hot Standby. Pause, |