Re: setlocale and gettext in Postgres

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: setlocale and gettext in Postgres
Date: 2011-02-01 08:08:26
Message-ID: AANLkTinUzDzB+ojS5CXD-CN-iuku-VCk06NOdDvOHt+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 1, 2011 at 5:36 AM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> 2011/1/27 Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>:
>> I see now the following lines in libintl.h of version
>> 0.18.1.1 which didn't exist in 0.17 version.
>>
>> The macro may cause a trouble especially on Windows.
>> Attached is a patch to disable the macro on Windows.
>
> Can anyone test the fix?
>
> I added the patch to the current commitfest for reminder.
> https://commitfest.postgresql.org/action/patch_view?id=528

The QA team in EDB have tested the patch for me. It works as designed
and allows us to upgrade gettext to fix Japanese localisation on
Win64. Upgrading gettext without the patch will fix Japanese, but
break other translations (eg. French).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2011-02-01 08:12:57 Re: Error code for "terminating connection due to conflict with recovery"
Previous Message Pavel Stehule 2011-02-01 06:56:15 Re: bad links in messages from commits