On Sat, Feb 19, 2011 at 2:45 AM, Peter Geoghegan
> Attached patch makes changes described to write() variants. What do you think?
> I conducted a little test to verify that I correctly changed all call
> sites - implicit casts can be tricky. Once I had finished changing the
> function names and their call sites, I provided an overload of write
> with const wxChar*, complete with implementation/definition. I then
> provided just a declaration of all the old overloads of write(). I
> wanted to see if I got any linker errors. The idea of the wxChar*
> variant (the one with the implementation) is to prevent any
> write(const wxString&, const wxChar*) calls from calling my
> write(bool) declaration, as they prefer that to write(const wxString&,
> const wxString&) . Anyway, none of the old declarations were called,
> and I saw no linker errors.
Looks good, and seems to work correctly on Windows (which is where I
was expecting problems).
Patch applied - thanks!
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
In response to
pgadmin-hackers by date
|Next:||From: Dave Page||Date: 2011-02-21 14:29:43|
|Subject: Re: pgAdmin III: adjust code as per new EDB AS90
|Previous:||From: Dave Page||Date: 2011-02-21 10:47:42|
|Subject: Re: pgAdmin III commit: Revert the previous change
that introduced sysSetti|