Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Support RIGHT and FULL OUTER JOIN in hash joins.
Date: 2010-12-31 05:09:56
Message-ID: AANLkTinNNV6kr7kmVtoUiQ0SQYxY1HdCk98P9yReQvMJ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, Dec 30, 2010 at 9:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> This is cool, but on first blush your changes to
>>> add_paths_to_joinrel() appear to be total nonsense.  I think the
>>> problem is that have_nonmergeable_clause is really a misnomer - it's
>>> not clear until you read through the whole diff that this won't get
>>> set for inner/left joins.
>
>> Yeah, I wasn't totally satisfied with that variable name either.
>> Do you have a better idea?
>
> On reflection, how about inverting the flag's value and calling it
> mergejoin_allowed or some such?

Yeah, that's better.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-12-31 17:00:07
Subject: pgsql: Invert and rename flag variable to improve code readability.
Previous:From: Tom LaneDate: 2010-12-31 03:13:09
Subject: pgsql: Move symbols for ExecMergeJoin's state machine intonodeMergejoi

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group