Re: Patch to support SSL certificate connections

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Patch to support SSL certificate connections
Date: 2011-01-28 01:11:36
Message-ID: AANLkTinN-A9Gj48p+b8Ccc6mDc4c5vwefeRV+ANidG_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>> Hi,
>>>>>
>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>> according to those.
>>>>>
>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>> and changes in the connection code to add those parameters in the
>>>>> connection string.
>>>>>
>>>>
>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>
>>>> Comments?
>>>
>>> I would move root cert up before the others. Also CRL.
>>>
>>> Root cert and CRL are about validating the *server* certificate. Key
>>> and cert file are about SSL authentication of the *client* (thus
>>> *client* certificates). They should definitely be in that order -
>>> perhaps even grouped with a headline?
>>>
>>
>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>
>
> Here is what I finally managed to do. Comments?

Why the change from the standard layout used everywhere else?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2011-01-28 03:58:17 Re: Patch to support SSL certificate connections
Previous Message Guillaume Lelarge 2011-01-27 21:56:05 Re: Patch to support SSL certificate connections