Skip site navigation (1) Skip section navigation (2)

Re: create tablespace fails silently, or succeeds improperly

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Dave Cramer <pg(at)fastcrypt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: create tablespace fails silently, or succeeds improperly
Date: 2010-10-18 18:19:44
Message-ID: AANLkTinHzGf4ah5Wj2V3MCYSX2FzKo4CS1e_jckCmyzC@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Oct 18, 2010 at 2:17 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Dave Cramer wrote:
>> On Mon, Oct 18, 2010 at 11:37 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> > Dave Cramer <pg(at)fastcrypt(dot)com> writes:
>> >> as seen below create tablespace does not throw an error or appear to
>> >> do anything other than register the tablespace.
>> >
>> > I suspect this behavior is partially intentional, because tablespace
>> > creation now involves an extra level of subdirectory. ?However, it's
>> > not clear to me why CREATE TABLESPACE is still changing the permissions
>> > on the parent directory. ?Bruce, exactly what is the rationale here?
>>
>> OK, it appears there are a few loose ends here then as the
>> documentation http://www.postgresql.org/docs/9.0/interactive/sql-createtablespace.html
>> says the directory needs to be empty.
>
> Docs updated to say "should", not "must", be empty.  Backpatched to
> 9.0.X.  If we need more change, I can do those too.

Perhaps we should fix the behavior rather than the documentation.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-10-18 18:20:02
Subject: Re: create tablespace fails silently, or succeeds improperly
Previous:From: Robert HaasDate: 2010-10-18 18:17:55
Subject: Re: ISN patch that applies cleanly with git apply

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group