From:
Robert Haas <robertmhaas(at)gmail(dot)com>
To:
Bruce Momjian <bruce(at)momjian(dot)us>
Cc:
Dave Cramer <pg(at)fastcrypt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: create tablespace fails silently, or succeeds improperly
Date:
2010-10-18 18:19:44
Message-ID:
AANLkTinHzGf4ah5Wj2V3MCYSX2FzKo4CS1e_jckCmyzC@mail.gmail.com (view raw or flat )
Thread:
2010-10-18 15:23:40 from Dave Cramer <pg(at)fastcrypt(dot)com>
2010-10-18 15:31:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2010-10-18 18:20:02 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:35:21 from Dave Cramer <pg(at)fastcrypt(dot)com>
2010-10-18 18:39:47 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:44:09 from Dave Cramer <pg(at)fastcrypt(dot)com>
2010-10-18 18:56:03 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:57:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 15:37:44 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 17:24:58 from Dave Cramer <pg(at)fastcrypt(dot)com>
2010-10-18 18:17:31 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:19:44 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-10-18 18:29:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 19:02:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 19:03:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-10-18 19:05:04 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 19:07:16 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-10-18 19:16:35 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 19:21:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 19:29:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-10-18 19:50:58 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 20:02:01 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-12-10 20:26:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-10 22:54:23 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-10 23:01:44 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-10 23:08:38 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2010-12-11 03:33:16 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 03:41:18 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-11 04:17:21 from Stephen Frost <sfrost(at)snowman(dot)net>
2010-12-11 15:56:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 18:15:45 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-11 18:20:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-11 18:23:10 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-11 18:38:28 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-12-12 01:56:40 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-12-12 22:04:11 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2010-12-12 23:10:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 19:04:14 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:26:32 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-10-18 18:59:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-10-18 19:03:22 from Bruce Momjian <bruce(at)momjian(dot)us>
Lists:
pgsql-hackers
On Mon, Oct 18, 2010 at 2:17 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Dave Cramer wrote:
>> On Mon, Oct 18, 2010 at 11:37 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> > Dave Cramer <pg(at)fastcrypt(dot)com> writes:
>> >> as seen below create tablespace does not throw an error or appear to
>> >> do anything other than register the tablespace.
>> >
>> > I suspect this behavior is partially intentional, because tablespace
>> > creation now involves an extra level of subdirectory. ?However, it's
>> > not clear to me why CREATE TABLESPACE is still changing the permissions
>> > on the parent directory. ?Bruce, exactly what is the rationale here?
>>
>> OK, it appears there are a few loose ends here then as the
>> documentation http://www.postgresql.org/docs/9.0/interactive/sql-createtablespace.html
>> says the directory needs to be empty.
>
> Docs updated to say "should", not "must", be empty. Backpatched to
> 9.0.X. If we need more change, I can do those too.
Perhaps we should fix the behavior rather than the documentation.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2010-10-18 18:20:02Subject : Re: create tablespace fails silently, or succeeds
improperlyPrevious :From : Robert HaasDate : 2010-10-18 18:17:55Subject : Re: ISN patch that applies cleanly with git apply
