Skip site navigation (1) Skip section navigation (2)

Re: Feature request: drop rules

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Thom Brown <thombrown(at)gmail(dot)com>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Feature request: drop rules
Date: 2010-07-21 14:46:49
Message-ID: AANLkTinH-JycySuFK75dq9RZEmt8h0QqVA3tIFlD76t3@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Wed, Jul 21, 2010 at 2:44 PM, Thom Brown <thombrown(at)gmail(dot)com> wrote:
> On 21 July 2010 14:32, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> On Wed, Jul 21, 2010 at 2:26 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>>
>>> Tried it. Still works for me. I'm on Linux, but I don't think it is the
>>> issue :)
>>
>> Actually, it might be. pgRule::CanDrop() is calling schema->CanDrop(),
>> however schema actually contains the table object. I think this is
>> because rules can exist under tables and views, so originally deriving
>> them from pgTableObject seemed wrong.
>>
>>
>> --
>
> I create a rule on a view, it comes up with the "Drop/Delete" and
> "Drop Cascaded" options.

I've pushed a commit that should fix this (as well as some icon
improvements that I previously forgot to push). You now get the option
to drop a rule from a table or view (though not if it's "the" rule
that implements the view), and no longer get the option to create
rules on system views.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgadmin-hackers by date

Next:From: Thom BrownDate: 2010-07-21 15:01:14
Subject: Re: Feature request: drop rules
Previous:From: Thom BrownDate: 2010-07-21 13:44:09
Subject: Re: Feature request: drop rules

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group