Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Date: 2010-09-26 15:48:37
Message-ID: AANLkTinBe=Vz8200ScP+PE7HLO4LtVj606mgA4VHpVJA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Sep 26, 2010 at 1:51 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Still more tweaking of git_changelog.
>
> 1. Don't assume there's only one candidate match; check them all and use the
> one with the closest timestamp.  Avoids funny output when someone makes
> several successive commits with the same log message, as certain people
> have been known to do.
>
> 2. When the same commit (with the same SHA1) is reachable from multiple
> branch tips, don't report it for all the branches; instead report it only
> for the first such branch.  Given our development practices, this case
> arises only for commits that occurred before a given branch split off from
> master.  The original coding blamed old commits on *all* the branches,
> which isn't terribly useful; the new coding blames such a commit only on
> master.

Uhm, could you stop massively changing the behavior of this script
with no discussion at all?  I happen to think that this is a
distinctly bad idea.  It defeats one of the major use cases of the
original script, which is being able to easily figure out which
branches a certain commit is in.  If you want to have an option for
this behavior, fine, but please do not presume that everyone wants the
same thing as you (since that is evidently not the case) or that you
are the only person who is using it (if that were so, it should be
stored in your personal workspace, rather than our community
repository).

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-09-26 15:55:31
Subject: Re: Documentation, window functions
Previous:From: Marios VodasDate: 2010-09-26 15:35:10
Subject: C function to return tuple

pgsql-committers by date

Next:From: Tom LaneDate: 2010-09-26 16:08:38
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Previous:From: Peter EisentrautDate: 2010-09-26 11:42:05
Subject: pgsql: Add ALTER TYPE ... ADD/DROP/ALTER/RENAME ATTRIBUTE

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group