| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts. |
| Date: | 2010-12-17 16:34:48 |
| Message-ID: | AANLkTin=Kx3R0mi5ccLg3mvaDpD7kbFrBg+C4kt4r=r_@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Dec 17, 2010 at 11:20 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Dec 17, 2010 at 9:52 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I imagine the reason for the original coding was to avoid a useless
>>> gettimeofday kernel call in the common case that there are no
>>> conflicting xacts to wait for. Could we restore that behavior?
>
>> Something like the attached?
>
> I would just add the return-at-the-top. Changing the loop logic is
> not necessary --- the loop test is cheap.
Hmm... that's a fine bit of hairsplitting, but OK.
Done that way, then.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2010-12-17 17:00:52 | pgsql: Backpatch plperl GNUmakefile fixes to allow building release 8.2 |
| Previous Message | Robert Haas | 2010-12-17 16:33:02 | pgsql: Try to save a kernel call in ResolveRecoveryConflictWithVirtualX |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-17 16:38:22 | Re: proposal: FOREACH-IN-ARRAY (probably for 9.2?) |
| Previous Message | Peter Eisentraut | 2010-12-17 16:28:12 | Re: Unnecessary limit on max_standby_streaming_delay |