Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take
Date: 2011-02-16 18:50:39
Message-ID: AANLkTin=44pYtJCigjf2-QZhnG24=zhq5hpryOWTHGh_@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On 16 February 2011 18:42, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> The main issue I have with that is that we now have a bunch of
> overloaded Write() members, and WriteBool(). If we're going to deviate
> away from the API in wxConfig (which at least is private), then we
> should do so consistently.
>
> FYI, in wxPython and wxPerl they implement the following:
>
> Write(key, value)        Writes a string
> WriteInt(key, value)     Writes an integer
> WriteFloat(key, value)   Writes a floating point number
> WriteBool(key, value)    Writes a boo

I totally agree. What about ctlListView? The fact that its
AppendYesNoItem() member function doesn't overload AppendItem() is, as
I said at the time, logical, because you aren't actually appending a
true or false value - you're appending a "Yes" or a "No".

--
Regards,
Peter Geoghegan

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2011-02-16 18:58:49 Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take
Previous Message Dave Page 2011-02-16 18:42:26 Re: pgAdmin III commit: Include a variant of sysSettings::Write() that take