Re: compiler warning

On Thu, Feb 3, 2011 at 04:40, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> I am seeing the following compiler warning for the past few days:
>
>        basebackup.c:213: warning: variable `ptr' might be clobbered by
>        `longjmp' or `vfork'
>
> and I see this comment in the file:
>
>        /*
>         * Actually do a base backup for the specified tablespaces.
>         *
>         * This is split out mainly to avoid complaints about "variable might be
>         * clobbered by longjmp" from stupider versions of gcc.
>         */
>
> Seems that isn't working as expected.  I am using:
>
>        gcc version 2.95.3 20010315 (release)
>
> with -O1.

This is the same warning Tom fixed earlier. I have no idea what
actually causes it :(

I think it's somehow caused by the PG_ENSURE_ERROR_CLEANUP stuff.
Does it go away if you break everything inside the if
(opt->includewal) into it's own function? (Or at least everything
except the pq_putemptymessage() call, because moving that would make
the code very confusing)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/