Skip site navigation (1) Skip section navigation (2)

Re: Caution when removing git branches

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Caution when removing git branches
Date: 2011-01-27 16:13:22
Message-ID: AANLkTin9F4L_QzmgmU=0E6w4fhWrdrLB_-69c6H8RmEV@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Jan 26, 2011 at 17:37, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 01/26/2011 11:26 AM, Bruce Momjian wrote:
>>
>> For those of you using git, I wanted to point out that it is fairly easy
>> to remove git branches.  For example, I can easily remove a branch on
>> my github repository using:
>>
>>        $ git branch -d :branch_name
>>
>> I don't believe that is revertable.  What is scarey is that this could
>> be done on our 'origin' as well.
>>
>
> The ability to remove branches is a feature. I strongly encourage you to
> create topic branches for development work, then merge them onto the main
> branch, and then delete them. I almost never work directly on, say,
> REL9_0_STABLE or master, except for quite trivial changes.
>
> I thought we had some hooks on gitmaster to help prevent accidents like
> inadvertent branch deletion.

We have hooks to prevent a number of things, but not the removal of
branches (or tags). We'll send an email to committers telling you it's
been done, but we don't prevent it.

It would probably be pretty easy to add a hook preventing it though -
do we want that? (we could still delete branches of course - but it
would require an admin to do it directly on the git server, which is
highly unlikely to happen by mistake)

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2011-01-27 16:22:12
Subject: Re: Re: In pg_test_fsync, use K(1024) rather than k(1000) for write size units.
Previous:From: Bruce MomjianDate: 2011-01-27 15:53:23
Subject: Re: Re: In pg_test_fsync, use K(1024) rather than k(1000) for write size units.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group