From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: BUG #5705: btree_gist: Index on inet changes query result |
Date: | 2010-10-19 20:57:05 |
Message-ID: | AANLkTin4Qt4XVF8s1UxHP36guTDHdSUPmCFukF0Oimw4@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Mon, Oct 11, 2010 at 7:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Andreas Karlsson" <andreas(at)proxel(dot)se> writes:
>> I was looking at the code to see how one would improve indexing of the inet
>> types and saw an inconsistency between the compressed format
>> (gbt_inet_compress) and how network_cmp_internal works. The btree_gist
>> module ignores the netmask.
>
> Well, actually the btree_gist implementation for inet is a completely
> broken piece of junk: it thinks that convert_network_to_scalar is 100%
> trustworthy and can be used as a substitute for the real comparison
> functions, which isn't even approximately true. I'm not sure why
> Teodor implemented it like that instead of using the type's real
> comparison functions, but it's pretty much useless if you want the
> same sort order that the type itself defines.
Are you planning to fix this?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-10-19 22:22:29 | Re: BUG #5705: btree_gist: Index on inet changes query result |
Previous Message | Robert Haas | 2010-10-19 20:55:13 | Re: Recovery bug |