Re: PATCH: FB#15944: An error has occurred if debug function

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: FB#15944: An error has occurred if debug function
Date: 2010-06-08 10:31:16
Message-ID: AANLkTin3kT-x5hd4ldZHqZiccoaEBHcSRdXUNbDpxMMH@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Jun 8, 2010 at 7:17 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> On Tue, Jun 8, 2010 at 1:20 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> On Mon, Jun 7, 2010 at 4:31 PM, Ashesh Vashi
>> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> > HI Dave,
>> > Please find the patch for the same.
>> > If plpgsql does have out parameter, it fails to debug.
>> > This patch will apply on both trunk and REL-1_10_PATCHES branch.
>>
>> Hi Ashesh,
>>
>> Is that patch right? Surely we should never try to pass a value into
>> an OUT parameter.
>
> You're right.
> We never ask for input from the user for the OUT parameter and the argument
> value will always be NULL for these parameters. And hence, this patch worked
> for me.
> Please find the updated patch.

Thanks - patch applied.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2010-06-08 12:11:44 PATCH: FB#15842: Error occur when try to add comments in package property
Previous Message svn 2010-06-08 10:31:05 SVN Commit by dpage: r8417 - in trunk/pgadmin3: . pgadmin/debugger