| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER OBJECT any_name SET SCHEMA name |
| Date: | 2010-11-04 15:33:22 |
| Message-ID: | AANLkTin-J6GFoRdpFHE=md-xLamQzrgqxutTT+C7Tw61@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 4, 2010 at 8:18 AM, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Nov 4, 2010 at 7:52 AM, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
>>> What about create_extension_extension instead? I'm not thinking of
>>> something better, bikeshedding is opened.
>>
>> That doesn't seem very clear... I'm always suspicious of names that
>> use the same word twice, and in this case I have no idea what this
>> variable would supposedly refer to.
>
> The ObjectAddress of the extension currently being installed by the
> CREATE EXTENSION command we're "in" (executing the script). The variable
> create_extension is already a boolean only set to true if in the code
> path.
How about calling it CurrentExtensionObjectAddress or something like
that? And maybe you don't need a boolean: if
(OidIsValid(CurrentExtensionObjectAddress.objid)) ...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-11-04 15:48:12 | Re: ALTER OBJECT any_name SET SCHEMA name |
| Previous Message | Dimitri Fontaine | 2010-11-04 15:18:13 | Re: ALTER OBJECT any_name SET SCHEMA name |