Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds
Date: 2011-01-09 17:07:39
Message-ID: AANLkTin-3Dy8+COq9-UZGT-xqGFVDK-mRuNMpDZ++Mbp@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Jan 9, 2011 at 17:49, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Sun, Jan 9, 2011 at 17:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'd like to protest this patch as misguided.  AFAICS it is a *seriously*
>
>> Uh, we install the file on Unix, so we should do the same on Windows.
>
> Well, my idea of how to fix that would be the other way 'round.

Sure, then it's at least consistent...


>>> What we really need to be asking is why the pgAdmin folks think
>>> they should be including it.
>
>> It is required in order to pull kwlist.h,
>
> No, it is not required.  What they should be doing is #define'ing
> PG_KEYWORD() in a way that ignores its second argument.  See pg_dump's
> keywords.c for an example of safe usage.

Ahh, good point.

And yes, that seems to work for pgadmin. I'll commit a patch there as
soon as I've finished testing, at which point it won't be required
anymore.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2011-01-09 17:55:49
Subject: SSI and 2PC
Previous:From: Tom LaneDate: 2011-01-09 16:49:00
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

pgsql-committers by date

Next:From: Tom LaneDate: 2011-01-09 18:09:38
Subject: pgsql: Use array_contains_nulls instead of ARR_HASNULL onuser-supplied
Previous:From: Tom LaneDate: 2011-01-09 16:49:00
Subject: Re: [COMMITTERS] pgsql: Properly install gram.h on MSVC builds

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group