Skip site navigation (1) Skip section navigation (2)

Re: [RRR] [HACKERS] Commitfest: The Good, The Bad, and the Ugly

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, PostgreSQL General <pgsql-general(at)postgresql(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Round Robin Reviewers <pgsql-rrreviewers(at)postgresql(dot)org>
Subject: Re: [RRR] [HACKERS] Commitfest: The Good, The Bad, and the Ugly
Date: 2010-09-29 02:16:51
Message-ID: AANLkTimyS41SiQ=m98wkOy=9YMpC67ECiorNmGhRLQau@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackerspgsql-rrreviewers
On Tue, Sep 28, 2010 at 9:33 PM, Itagaki Takahiro
<itagaki(dot)takahiro(at)gmail(dot)com> wrote:
> On Wed, Sep 29, 2010 at 10:18 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> No, the column is very clearly labelled "Reviewers", not "Reviewer".
>> And we have certainly had patches with more than one person's name in
>> that field in the past.  The issue is rather that we don't have enough
>> people reviewing.  We haven't had enough people volunteer to do
>> reviews to even assign ONE person to each patch, let alone two.  There
>> are, as of this writing, SEVEN patches that have no reviewer at all.
>
> Some of them might be too difficult to review. For example, replication
> or snapshot management requires special skills to review.
>
> I'm worrying about new reviewers hesitate to review a patch that has
> a previous reviewer, and then, if they think the remaining patches are
> too difficult for them, they would just leave the commitfest page.

That's a legitimate concern, but I am not sure how much of a problem
it is in practice.  Most people who become round-robin reviewers are
getting pulled into the process a little more than just stumbling
across the CF page by happenstance, or at least I hope they are.  Not
all patches can benefit from multiple reviewers, but CF managers can
and should encourage multiple reviews of those that can.  However, at
the moment, the problem is that regardless of who is assigned to do
what, we're not getting enough reviews done.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2010-09-29 02:27:08
Subject: Re: Proposal: plpgsql - "for in array" statement
Previous:From: Andy ColsonDate: 2010-09-29 02:15:28
Subject: Re: [RRR] [HACKERS] Commitfest: The Good, The Bad, and the Ugly

pgsql-rrreviewers by date

Next:From: Marko TiikkajaDate: 2010-09-29 19:14:07
Subject: Re: [HACKERS] top-level DML under CTEs
Previous:From: Andy ColsonDate: 2010-09-29 02:15:28
Subject: Re: [RRR] [HACKERS] Commitfest: The Good, The Bad, and the Ugly

pgsql-general by date

Next:From: Darren DuncanDate: 2010-09-29 02:18:27
Subject: Re: How to handle results with column names clash
Previous:From: Andy ColsonDate: 2010-09-29 02:15:28
Subject: Re: [RRR] [HACKERS] Commitfest: The Good, The Bad, and the Ugly

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group