Skip site navigation (1) Skip section navigation (2)

Re: Add ENCODING option to COPY

From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add ENCODING option to COPY
Date: 2011-02-01 02:16:54
Message-ID: AANLkTimwqEZogL6Q9mnn7gJ7snpBTnWfhcQoTxctHpGi@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2011/2/1 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
>> Finally I concluded the concern Itagaki-san raised can be solved by
>> adding code that restores client_encoding in copy_in_error_callback.
>
> It might happen to work today (or at least in the scenarios you tested),
> but it seems fragile as can be.

Although I thought its fragile-ness was acceptable to avoid making the
patch too complex, I agree with you.
The third patch is attached, modifying mb routines so that they can
receive conversion procedures as FmgrInof * and save the function
pointer in CopyState.
I tested it with encoding option and could not see performance slowdown.

Regards,


-- 
Hitoshi Harada

Attachment: copy_encoding.v3.patch
Description: application/octet-stream (1.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Thom BrownDate: 2011-02-01 02:17:17
Subject: Re: Issues with generate_series using integer boundaries
Previous:From: Tom LaneDate: 2011-02-01 01:52:04
Subject: Re: Error code for "terminating connection due to conflict with recovery"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group