Skip site navigation (1) Skip section navigation (2)

Re: 4 spaces versus tabs

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: 4 spaces versus tabs
Date: 2010-11-11 21:10:02
Message-ID: AANLkTimqXxdEEdsdbEafs6xme_w6cunSzftq3QoZXUxx@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Nov 2, 2010 at 5:52 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 24/10/2010 07:49, Dave Page a écrit :
>> On Sun, Oct 24, 2010 at 2:22 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> IIRC, we should use spaces and not tabs. If I look into the code, I see
>>> many tabs in it. I can of course configure my editor to display them as
>>> four tabs, but I would really like to get rid of them.
>>>
>>> Any objections? because it would be a hell of a patch (90427 replacements)
>>
>> Go for it. The project standard is for spaces.
>>
>> Though, if we're going to make such a big change, I have to wonder if
>> tabs would be a more convenient choice in hindsight...
>>
>
> Actually, I don't like tabs :)
>
> But I don't care that much. What I would like to have is a nice source
> code, and, now, it doesn't look that nice.
>
> So, if it is tabs, so be it :)

I like tabs, but that's just me, and I don't work on pgAdmin.  It
sucks trying to move back and forth between projects with different
styles, though, and pgsql uses tabs.

Another thing to consider if you're thinking about a massive fixup
commit is removing trailing whitespace.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2010-11-11 21:24:36
Subject: Re: 4 spaces versus tabs
Previous:From: pgAdmin TracDate: 2010-11-11 21:01:44
Subject: [pgAdmin III] #277: Little mistake in comment in inheriting table

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group