Skip site navigation (1) Skip section navigation (2)

Re: wip: functions median and percentile

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>
Subject: Re: wip: functions median and percentile
Date: 2010-09-21 21:03:31
Message-ID: AANLkTimhSBJifs771o3ofEiOakN78jJn+ac4XY=0g_Q9@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
2010/9/21 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Tue, Sep 21, 2010 at 4:28 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>> * Cosmetic coding style should be more appropriate, including trailing
>>> white spaces and indentation positions.
>>
>> can you specify where, please?
>
> I noticed a lot of problems in this area when working on your \ef /
> \sf patch, too.  Trailing whitespace is nearly always bad, and it's
> not hard to find - just grep the diff for it.  As for indentation, try
> to match the surrounding code.

is updated patch better?

Pavel

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise Postgres Company
>

Attachment: median.diff
Description: text/x-patch (12.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-09-21 21:09:09
Subject: Is src/tools/add_cvs_markers still of any use?
Previous:From: Pei HeDate: 2010-09-21 21:02:53
Subject: Get the offset of a tuple inside a table

pgsql-rrreviewers by date

Next:From: Hitoshi HaradaDate: 2010-09-22 02:21:01
Subject: Re: wip: functions median and percentile
Previous:From: Robert HaasDate: 2010-09-21 20:44:16
Subject: Re: wip: functions median and percentile

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group