Re: Comments on SQL/Med objects

On Fri, Apr 1, 2011 at 9:40 AM, Shigeru HANADA
<hanada(at)metrosystems(dot)co(dot)jp> wrote:
> On Thu, 31 Mar 2011 11:24:27 -0400
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Attached.  Foreign tables are already OK, I believe; it's only foreign
>> data wrappers and foreign servers that appear to need fixing.
>
> The patch seems good for basic functionarity.  I've tested the patch
> and noticed that get_foreign_data_wrapper_oid() is same as
> GetForeignDataWrapperOidByName(), so they could be merged.  Also
> GetForeignServerOidByName() could be merged.
>
> I changed "foreign data wrapper" in message to "foreign-data wrapper"
> for consistency, but it's revertable.
>
> Please see merge_oid_funcs.patch which can be applied onto your patch.

Thanks for the review, good catches. Committed those two patches
together with a bit of further rearrangement.

> I think some supports can be added for comments on SQL/MED objects.
>
>  - pg_dump support for comment on fdw and server
>  - psql describe commands (\dew+ and \des+)
>  - psql TAB completion
>
> Please see attached patches for each feature.

I'll take a look at these next.

> While testing pg_dump, I noticed that comment of extension's member
> objects are not dumped by pg_dump.  Those comments should be dumped
> after CREATE EXTENSION statement?

No, I don't believe that would be correct.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company