Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

From: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date: 2011-02-18 18:01:56
Message-ID: AANLkTimdfdhBpFo7Pn19gANU3SGhDuvCNckBRC1YLV1D@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On 18 February 2011 16:46, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> I'm not sure that helps - the issue is that the current code reads the
> string "true" and treats it as a boolean. What we need to do is ensure
> we always write booleans as strings, otherwise it won't be backwards
> compatible. Then, ReadBool() just reads a string value, and converts
> it.

Sure, we should be calling exactly the same function, but with a
slightly different interface (at least in the case of write()
variants). I thought that the interface inconsistency between read()
and write() variants might be a problem for you.


-- 
Regards,
Peter Geoghegan

In response to

Responses

pgadmin-hackers by date

Next:From: Peter GeogheganDate: 2011-02-19 02:45:29
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Previous:From: Dave PageDate: 2011-02-18 16:48:57
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group