Skip site navigation (1) Skip section navigation (2)

Re: Comments on SQL/Med objects

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Comments on SQL/Med objects
Date: 2011-03-31 15:24:27
Message-ID: AANLkTimS1tDEuEeocz9PBjQ-RLSdjJ+VKFc_+F+Jm3Ou@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Mar 28, 2011 at 12:29 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Mar 28, 2011 at 12:06 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> On Wed, Mar 23, 2011 at 12:53 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> Yeah, I had a private TODO about that.  I'd like to see if we can
>>>> refactor the grammar to eliminate some of the duplication there
>>>> as well as the potential for oversights of this sort.  I believe
>>>> that USER MAPPINGs are missing from ObjectType as well as a bunch
>>>> of other basic places ...
>>
>>> Are you going to work on this?  If not I can pick it up, at least
>>> insofar as making the comment stuff work across the board.
>>
>> I'm still up to my rear in collations, so feel free.
>
> OK.  I'll work on it this week.

Attached.  Foreign tables are already OK, I believe; it's only foreign
data wrappers and foreign servers that appear to need fixing.

The fact that foreign data wrapper is sometimes abbreviated to fdw and
sometimes not does nothing for the greppability of the code.  I'm
wondering if we should go through and fix the constants that
abbreviate it:

ACL_KIND_FDW
ACL_ALL_RIGHTS_FDW
OBJECT_FDW
OCLASS_FDW

It seems to me that it would be a whole lot clearer and easier if
these all spelled it out FOREIGN_DATA_WRAPPER, as we do for similar
object types.  Other than a pretty minute back-patch hazard, I don't
see much down side.  Thoughts?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment: foreign-comment.patch
Description: application/octet-stream (11.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Brendan JurdDate: 2011-03-31 15:27:02
Subject: Re: [HACKERS] Date conversion using day of week
Previous:From: Robert HaasDate: 2011-03-31 15:11:49
Subject: Re: BUG #5856: pg_attribute.attinhcount is not correct.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group